fix: avoid pickling MCP sessions when copying GenerateContentConfig - #2811
Open
a2105z wants to merge 1 commit into
Open
fix: avoid pickling MCP sessions when copying GenerateContentConfig#2811a2105z wants to merge 1 commit into
a2105z wants to merge 1 commit into
Conversation
Async generate_content deep-copied config objects and crashed when tools included an MCP ClientSession holding an asyncio.Future. Clear tools before deep copy and reattach by reference, matching the existing MCP parse helpers. Fixes googleapis#2669.
Author
|
@Venkaiahbabuneelam this PR fixes the async generate_content pickle crash when GenerateContentConfig includes an MCP ClientSession tool; whenever you have a moment, I would really appreciate your review — thank you for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncModels.generate_content/generate_content_streamcrashed withTypeError: cannot pickle '_asyncio.Future'whenconfigwas aGenerateContentConfigcontaining an MCPClientSessiontool (dict configs already worked).copy_generate_content_configthat clearstoolsbefore deep copy (Pydantic deep-copies before applyingupdate), then reattaches tools by reference—same approach as the existing MCP parse helpers.Test plan
pytest google/genai/tests/mcp/test_copy_generate_content_config.py google/genai/tests/mcp/test_parse_config_for_mcp_sessions.pyClientSessiontools withoutTypeErrorawait client.aio.models.generate_content(..., config=GenerateContentConfig(tools=[mcp_session]))