fix: export interactions.Interaction as the resource class for mypy - #2810
Open
a2105z wants to merge 1 commit into
Open
fix: export interactions.Interaction as the resource class for mypy#2810a2105z wants to merge 1 commit into
a2105z wants to merge 1 commit into
Conversation
Stop star-importing the triggers Interaction TypeAliasTypes into google.genai.interactions so mypy resolves Interaction to the resource class, matching runtime behavior. Fixes googleapis#2732
Author
|
@Venkaiahbabuneelam this PR makes google.genai.interactions.Interaction resolve to the resource class under mypy instead of the triggers alias; whenever you have a moment, I would really appreciate your review — thank you for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interaction/InteractionParamTypeAliasTypes intogoogle.genai.interactions.from google.genai.interactions import Interactionto the resource class (matching runtime), soisinstance(...)and field access type-check correctly.google.genai._gaos.types.triggers.Background
interactions.pypreviously didfrom ._gaos.types.triggers import *before importing the interactions resource types and relied on last-binding-wins. That works at runtime and for pyright, but mypy keeps the first star-import binding, so typed users sawTypeAliasTypeinstead of the resource class.Test plan
pytest google/genai/tests/interactions/test_interaction_type_export.pyreveal_type(Interaction)resolves to the resource class (notTypeAliasType)Interactionalias still importable fromgoogle.genai._gaos.types.triggers