fix: parse mldev batch input config source#2451
Open
MukundaKatta wants to merge 2 commits into
Open
Conversation
|
Hi @MukundaKatta, Thanks for reaching out us! Some checks have failed, please resolve the conflicts. Thanks |
…om_mldev The branch referenced _InlinedRequest_from_mldev, which does not exist (only the _to_mldev direction is generated), breaking mypy. mldev batch responses expose a file source; inline requests are request-only. Keep the file_name parsing that the test covers.
Contributor
Author
|
Thanks for the nudge. The failing check was mypy: the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2367.
Summary
Tests