This repository was archived by the owner on Mar 2, 2026. It is now read-only.
Merged
Conversation
gkevinzheng
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_aggregation_query_get_stream_iterator_read_time_different_timezonescurrently fails when run in non-utc timezonesThis section will build a different datetime value depending on the local machine's clock, since it's all based on a naive timestamp:
But the assertion assumes that the resulting timestamp value will be a fixed time in utc:
To fix this, I changed it to use datetime.fromtimestamp(1800, tz=custom_timezone)