Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

feat: Add fields for Pub/Sub triggers 
 feat: Implementation of Source Manifests#99

Merged
gcf-merge-on-green[bot] merged 1 commit into
masterfrom
update-owl-bot-begin-after-commit-hash
May 14, 2021
Merged

feat: Add fields for Pub/Sub triggers 
 feat: Implementation of Source Manifests#99
gcf-merge-on-green[bot] merged 1 commit into
masterfrom
update-owl-bot-begin-after-commit-hash

Conversation

@parthea

@parthea parthea commented May 14, 2021

Copy link
Copy Markdown
Contributor

PR #98 included changes to the generated client but the conventional commit messages were not included in the PR. This PR updates the begin-after-commit-hash that owl-bot uses to pull changes from googleapis-gen to match this commit.

The following changes are already in master:
fix: add async client to %name_%version/init.py
chore: add autogenerated snippets
chore: remove auth, policy, and options from the reserved names list
feat: support self-signed JWT flow for service accounts
chore: enable GAPIC metadata generation
chore: sort subpackages in %namespace/%name/init.py
feat: Add fields for Pub/Sub triggers 

feat: Implementation of Source Manifests

  • Added message StorageSourceManifest as an option for the Source message
  • Added StorageSourceManifest field to the SourceProvenance message

@parthea
parthea requested review from a team and busunkim96 May 14, 2021 13:54
@product-auto-label product-auto-label Bot added the api: cloudbuild Issues related to the googleapis/python-cloudbuild API. label May 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2021
@parthea parthea changed the title chore: Update Owl bot begin-after-commit-hash chore: Update Owl bot begin-after-commit-hash May 14, 2021
@parthea

parthea commented May 14, 2021

Copy link
Copy Markdown
Contributor Author

@busunkim96 PTAL

@parthea
parthea force-pushed the update-owl-bot-begin-after-commit-hash branch 2 times, most recently from aebd410 to f7123bb Compare May 14, 2021 16:01
@parthea

parthea commented May 14, 2021

Copy link
Copy Markdown
Contributor Author

I've pushed a new version to fix the failing conventional commits check

@parthea parthea changed the title chore: Update Owl bot begin-after-commit-hash chore: Update Owl bot hash May 14, 2021
@parthea
parthea force-pushed the update-owl-bot-begin-after-commit-hash branch from f7123bb to dca905d Compare May 14, 2021 16:02
@parthea
parthea force-pushed the update-owl-bot-begin-after-commit-hash branch from dca905d to 1b8d920 Compare May 14, 2021 16:03
@parthea parthea changed the title chore: Update Owl bot hash chore: Update Owl bot begin-after-commit-hash May 14, 2021
@parthea

parthea commented May 14, 2021

Copy link
Copy Markdown
Contributor Author

Fixed!

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label May 14, 2021
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 0b0255b into master May 14, 2021
@gcf-merge-on-green
gcf-merge-on-green Bot deleted the update-owl-bot-begin-after-commit-hash branch May 14, 2021 17:22
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 14, 2021
@parthea parthea changed the title chore: Update Owl bot begin-after-commit-hash feat: Add fields for Pub/Sub triggers 
 May 14, 2021
@parthea parthea changed the title feat: Add fields for Pub/Sub triggers 
 feat: Add fields for Pub/Sub triggers 
 feat: Implementation of Source Manifests May 14, 2021
@parthea parthea mentioned this pull request May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudbuild Issues related to the googleapis/python-cloudbuild API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants