Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

fix: correct Client and Connection type annotations #156

Merged
tswast merged 1 commit into from
Nov 10, 2021
Merged

fix: correct Client and Connection type annotations #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions google/cloud/_http/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import json
import os
import platform
from typing import Optional
from urllib.parse import urlencode
import warnings

Expand Down Expand Up @@ -168,19 +169,19 @@ class JSONConnection(Connection):
must be updated by subclasses.
"""

API_BASE_URL = None
API_BASE_URL: Optional[str] = None
"""The base of the API call URL."""

API_BASE_MTLS_URL = None
API_BASE_MTLS_URL: Optional[str] = None
"""The base of the API call URL for mutual TLS."""

ALLOW_AUTO_SWITCH_TO_MTLS_URL = False
"""Indicates if auto switch to mTLS url is allowed."""

API_VERSION = None
API_VERSION: Optional[str] = None
"""The version of the API, used in building the API call's URL."""

API_URL_TEMPLATE = None
API_URL_TEMPLATE: Optional[str] = None
"""A template for the URL of a particular API call."""

def get_api_base_url_for_mtls(self, api_base_url=None):
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class Client(_ClientFactoryMixin):
to acquire default credentials.
"""

SCOPE: Union[Tuple[str], None] = None
SCOPE: Union[Tuple[str, ...], None] = None
"""The scopes required for authenticating with a service.

Needs to be set by subclasses.
Expand Down