Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

tests: restore 100% unit test coverage for 'google.cloud.bigtable.client'#343

Merged
tseaver merged 6 commits into
masterfrom
335-tests-restore-coverage-client
Jun 25, 2021
Merged

tests: restore 100% unit test coverage for 'google.cloud.bigtable.client'#343
tseaver merged 6 commits into
masterfrom
335-tests-restore-coverage-client

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Jun 25, 2021

  • Tweak some docstrings for PEP 257 conformance.
  • Declare gRPC options at module scope
  • Clarify logic flow in Client._create_gapic_client_channel.

Toward #335.

@tseaver tseaver requested review from a team, chrisrossi, crwilcox and kolea2 June 25, 2021 17:29
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jun 25, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2021
Comment thread tests/unit/test_client.py
@tseaver tseaver changed the title Restore 100% unit test coverage for 'google.cloud.bigtable.client' tests: restore 100% unit test coverage for 'google.cloud.bigtable.client' Jun 25, 2021
@tseaver tseaver merged commit b4e07f8 into master Jun 25, 2021
@tseaver tseaver deleted the 335-tests-restore-coverage-client branch June 25, 2021 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants