Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: add 'Rowset.add_row_range_with_prefix'#30

Merged
tseaver merged 14 commits into
googleapis:masterfrom
MaxxleLLC:bigtable_issue_24
Aug 4, 2020
Merged

feat: add 'Rowset.add_row_range_with_prefix'#30
tseaver merged 14 commits into
googleapis:masterfrom
MaxxleLLC:bigtable_issue_24

Conversation

@HemangChothani
Copy link
Copy Markdown
Contributor

Fixes #24

@HemangChothani HemangChothani requested a review from crwilcox May 8, 2020 13:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@HemangChothani
Copy link
Copy Markdown
Contributor Author

System test failed is not relevant to changes, it throws error like Operation successfully rolled back : Insufficient node quota

@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
Comment thread google/cloud/bigtable/row_set.py Outdated
Comment thread docs/snippets_table.py Outdated
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @crwilcox any additional concerns?

@tseaver tseaver changed the title feat(bigtable): add support read row by prefix feat: add 'Rowset.add_row_range_with_prefix' Aug 3, 2020
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Aug 3, 2020

System test failures due to leaked nodes (exceeding quota) and a (maybe related) 401 in the subsequent test's teardown.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@tseaver tseaver dismissed crwilcox’s stale review August 4, 2020 17:14

Requested change applied in 909ba28

@tseaver tseaver merged commit 4796ac8 into googleapis:master Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reading by prefix

6 participants