This repository was archived by the owner on May 7, 2026. It is now read-only.
test: explicitly use US location for session in tests#650
Merged
Conversation
This avoids some warnings we see and ignore in our tests. It might also address some flakiness in `tests/system/small/ml/test_llm.py::test_create_text_generator_model` and `tests/system/small/ml/test_llm.py::test_create_text_generator_32k_model`, but the root cause of that flakiness is still TBD.
GarrettWu
approved these changes
May 1, 2024
ashleyxuu
approved these changes
May 1, 2024
shobsi
reviewed
May 1, 2024
| def session() -> bigframes.Session: | ||
| return bigframes.Session() | ||
| context = bigframes.BigQueryOptions( | ||
| location="US", |
Contributor
There was a problem hiding this comment.
This should already be the default
Contributor
Author
There was a problem hiding this comment.
Note that the line below that raises a warning. So this avoids that noise at least, even if it doesn't fix the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids some warnings we see and ignore in our tests.
It might also address some flakiness in
tests/system/small/ml/test_llm.py::test_create_text_generator_modelandtests/system/small/ml/test_llm.py::test_create_text_generator_32k_model, but the root cause of that flakiness is still TBD.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕