This repository was archived by the owner on May 7, 2026. It is now read-only.
refactor: unify row operators to same interface#100
Merged
gcf-merge-on-green[bot] merged 8 commits intomainfrom Jan 9, 2024
Merged
refactor: unify row operators to same interface#100gcf-merge-on-green[bot] merged 8 commits intomainfrom
gcf-merge-on-green[bot] merged 8 commits intomainfrom
Conversation
milkshakeiii
approved these changes
Oct 13, 2023
Contributor
milkshakeiii
left a comment
There was a problem hiding this comment.
LGTM but it's a large number of lines changed, perhaps a quick summary of what's here could help other reviewers? (Or just help me make sure what I think I'm seeing is indeed what I'm seeing?) Thanks!
tswast
approved these changes
Jan 8, 2024
| def register_unary_op( | ||
| self, | ||
| op_ref: typing.Union[ops.UnaryOp, type[ops.UnaryOp]], | ||
| pass_op: bool = False, |
Contributor
There was a problem hiding this comment.
Let's document that the purpose of this is for functions that need to pull out the parameterization from an op instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕