This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: allow queryJob.result() to be called on a dryRun#1015
Merged
tswast merged 3 commits intogoogleapis:mainfrom Oct 13, 2021
Merged
feat: allow queryJob.result() to be called on a dryRun#1015tswast merged 3 commits intogoogleapis:mainfrom
tswast merged 3 commits intogoogleapis:mainfrom
Conversation
tswast
suggested changes
Oct 11, 2021
Contributor
tswast
left a comment
There was a problem hiding this comment.
I think we can simplify the tests a bit.
|
|
||
| calls = conn.api_request.mock_calls | ||
| self.assertEqual(result, None) | ||
| self.assertEqual(calls, []) |
Contributor
There was a problem hiding this comment.
Awesome! Thanks for checking that there were no API requests.
tswast
reviewed
Oct 12, 2021
tswast
approved these changes
Oct 13, 2021
Contributor
|
Thanks @steffnay ! |
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
* feat: allow queryJob.result() to be called on a dryRun * update to return EmptyRowIterator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1012 🦕