Skip to content

feat: Added aiplatform.Model.update method - #952

Merged
ivanmkc merged 12 commits into
googleapis:mainfrom
ivanmkc:imkc--model-update-labels
Jan 24, 2022
Merged

feat: Added aiplatform.Model.update method#952
ivanmkc merged 12 commits into
googleapis:mainfrom
ivanmkc:imkc--model-update-labels

Conversation

@ivanmkc

@ivanmkc ivanmkc commented Jan 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added ability to update display_name, description and labels.

Fixes https://b.corp.google.com/issues/213921337

TODO

  • Manual test
  • Automated unit test
  • Automated integration test

Test code


models = Model.list()

my_model = models[0]

print(f"eTag: {my_model._gca_resource.etag}")
print(f"Current display_name: {my_model.display_name}")
my_model = my_model.update(display_name=my_model.display_name + "_new")
print(f"Current display_name: {my_model.display_name}")

print(f"eTag: {my_model._gca_resource.etag}")
my_model = Model(my_model.resource_name)  # Fetch model from server
print(f"eTag after fetch: {my_model._gca_resource.etag}")
print(f"Current description: {my_model.description}")
my_model = my_model.update(description=my_model.description + "_new")
print(f"Current description: {my_model.description}")

print(f"eTag: {my_model._gca_resource.etag}")
my_model = Model(my_model.resource_name)  # Fetch model from server
print(f"eTag after fetch: {my_model._gca_resource.etag}")
print(f"Current labels: {my_model.labels}")
my_model = my_model.update(labels={"my_label": "updated"})
print(f"Current labels: {my_model.labels}")

Bug?

There's some weirdness going on with the eTags though. If I don't "refetch" the model from the server, I get an "etag mismatch" exception on the subsequent update.

Tracked at b/214432914

@ivanmkc
ivanmkc requested a review from sasha-gitg January 11, 2022 20:50
@ivanmkc ivanmkc changed the title Added model.update method WIP: Added model.update method Jan 11, 2022
sasha-gitg
sasha-gitg reviewed Jan 11, 2022
View reviewed changes
Comment thread google/cloud/aiplatform/models.py Outdated
@ivanmkc ivanmkc changed the title WIP: Added model.update method Added model.update method Jan 13, 2022
ivanmkc
ivanmkc commented Jan 13, 2022
View reviewed changes
Comment thread google/cloud/aiplatform/models.py
@ivanmkc
ivanmkc force-pushed the imkc--model-update-labels branch from 79d31cb to 4a4a6b6 Compare January 13, 2022 22:25
@ivanmkc ivanmkc changed the title Added model.update method feat: Added model.update method Jan 13, 2022
@ivanmkc ivanmkc mentioned this pull request Jan 13, 2022
Closed
@ivanmkc ivanmkc linked an issue Jan 13, 2022 that may be closed by this pull request
Update asset labels of vertex ai models #928
Closed
sasha-gitg
sasha-gitg requested changes Jan 19, 2022
View reviewed changes

@sasha-gitg sasha-gitg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add or update an integration test to use this method:

An additional test case can be added here using the same model: https://github.com/googleapis/python-aiplatform/blob/main/tests/system/aiplatform/test_model_upload.py

It can also be added to this e2e test: https://github.com/googleapis/python-aiplatform/blob/main/tests/system/aiplatform/test_e2e_tabular.py

Comment thread google/cloud/aiplatform/models.py
Comment thread google/cloud/aiplatform/models.py
Comment thread google/cloud/aiplatform/models.py Outdated
@ivanmkc
ivanmkc force-pushed the imkc--model-update-labels branch from 783b162 to 48459c8 Compare January 21, 2022 22:34
sasha-gitg
sasha-gitg approved these changes Jan 24, 2022
View reviewed changes

@sasha-gitg sasha-gitg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread google/cloud/aiplatform/models.py Outdated
@ivanmkc @sasha-gitg
Update google/cloud/aiplatform/models.py
5dffb7f 
Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
@sasha-gitg sasha-gitg changed the title feat: Added model.update method feat: Added aiplatform.Model.update method Jan 24, 2022
@ivanmkc
ivanmkc merged commit 44e208a into googleapis:main Jan 24, 2022
@release-please release-please Bot mentioned this pull request Jan 24, 2022
Merged
@ivanmkc ivanmkc mentioned this pull request Jan 25, 2022
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jan 27, 2022
@ivanmkc
fix: Fixed integration test for model.upload (#975)
0ca3747 
Fixed bug in integration test introduced by #952
ivanmkc added a commit to ivanmkc/python-aiplatform that referenced this pull request Jan 28, 2022
@ivanmkc
fix: Fixed integration test for model.upload (googleapis#975)
f4cc2a7 
Fixed bug in integration test introduced by googleapis#952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update asset labels of vertex ai models

2 participants

@ivanmkc @sasha-gitg