Skip to content

feat: inside script training utils#71

Merged
sirtorry merged 13 commits into
googleapis:devfrom
sirtorry:training_utils
Nov 17, 2020
Merged

feat: inside script training utils#71
sirtorry merged 13 commits into
googleapis:devfrom
sirtorry:training_utils

Conversation

@sirtorry

@sirtorry sirtorry commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

adds env var helpers.
partially resolves b/169782082

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2020
@sirtorry sirtorry marked this pull request as ready for review November 16, 2020 23:18
@sirtorry sirtorry added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@sirtorry sirtorry changed the title feat: inside script env var helpers feat: inside script training utils Nov 16, 2020
@sirtorry sirtorry added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2020
@sirtorry

Copy link
Copy Markdown
Contributor Author

let me know if this implementation is satisfactory.

Comment thread google/cloud/aiplatform/training_utils.py Outdated
Comment thread google/cloud/aiplatform/training_utils.py Outdated
Comment thread google/cloud/aiplatform/training_utils.py Outdated
@sirtorry

Copy link
Copy Markdown
Contributor Author

current implementation returns None if env var not found. does that sound good?

@sirtorry sirtorry requested a review from sasha-gitg November 17, 2020 19:05

@sasha-gitg sasha-gitg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Type hinting corrections.

Comment thread google/cloud/aiplatform/training_utils.py Outdated
Comment thread google/cloud/aiplatform/training_utils.py Outdated
@sirtorry sirtorry merged commit 7cd4b14 into googleapis:dev Nov 17, 2020
@sirtorry sirtorry deleted the training_utils branch November 17, 2020 20:53
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants