fix(feature_store): safely parse bq:// URIs using removeprefix#6771
Open
mrishi wants to merge 1 commit into
Open
fix(feature_store): safely parse bq:// URIs using removeprefix#6771mrishi wants to merge 1 commit into
mrishi wants to merge 1 commit into
Conversation
The previous implementation used `.lstrip("bq://")`, which greedily
dropped valid characters (like 'b' or 'q') from the beginning of
Google Cloud Project IDs.
Replaced `lstrip` with `removeprefix` to explicitly remove only
the protocol string without mutating the project ID.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixed a bug in
fetch_historical_feature_valueswherebq_uri.lstrip("bq://")was greedily stripping valid characters (such as 'b' or 'q') from the beginning of Google Cloud Project IDs.Replaced
lstripwithremoveprefixto safely and explicitly remove only the protocol string without inadvertently mutating the project ID.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the
mainbranch and this PR will be closed.