feat: add support for distributed custom training#66
Merged
Conversation
vinnysenthil
approved these changes
Nov 16, 2020
Contributor
vinnysenthil
left a comment
There was a problem hiding this comment.
LGTM + tests pass, added a note about the default machine_type
| """ | ||
|
|
||
| replica_count: int = 0 | ||
| machine_type: str = "n1-standard-2" |
Contributor
There was a problem hiding this comment.
n1-standard-2 is supported in Deploy but not for Training.
n1-standard-4 is currently the lowest common denominator.
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Thanks! That's good to know. I was working off the machine_resource.MachineSpec proto comments.
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for chief-worker distributed training to custom training. If replica_count > 1 the remainder as provisioned as workers
The _DistributedTrainingSpec can also support more custom provisioning. We will have a follow up PR after we consider how we want to expose more custom provisioning on the API surface.
Note: If library upgrades to 3.7 we should switch the Spec classes to dataclass.
Fixes b/172369809 🦕