Skip to content

fix: Populate service_account and network in PipelineJob instead of pipeline_spec #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sasha-gitg merged 2 commits into from
Aug 26, 2021
Merged

fix: Populate service_account and network in PipelineJob instead of pipeline_spec #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f422f5
fix: Populate service_account and network in PipelineJob instead of p…
sasha-gitg Aug 26, 2021
af85adf
chore:lint
sasha-gitg Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/aiplatform/pipeline_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,10 @@ def run(
Optional. Whether to execute this method synchronously. If False, this method will unblock and it will be executed in a concurrent Future.
"""
if service_account:
self._gca_resource.pipeline_spec.service_account = service_account
self._gca_resource.service_account = service_account

if network:
self._gca_resource.pipeline_spec.network = network
self._gca_resource.network = network

_LOGGER.log_create_with_lro(self.__class__)

Expand Down
6 changes: 6 additions & 0 deletions tests/unit/aiplatform/test_pipeline_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ def mock_pipeline_service_create():
name=_TEST_PIPELINE_JOB_NAME,
state=gca_pipeline_state_v1beta1.PipelineState.PIPELINE_STATE_SUCCEEDED,
create_time=_TEST_PIPELINE_CREATE_TIME,
service_account=_TEST_SERVICE_ACCOUNT,
network=_TEST_NETWORK,
)
yield mock_create_pipeline_job

Expand All @@ -93,6 +95,8 @@ def make_pipeline_job(state):
name=_TEST_PIPELINE_JOB_NAME,
state=state,
create_time=_TEST_PIPELINE_CREATE_TIME,
service_account=_TEST_SERVICE_ACCOUNT,
network=_TEST_NETWORK,
)


Expand Down Expand Up @@ -239,6 +243,8 @@ def test_run_call_pipeline_service_create(
"root": _TEST_PIPELINE_JOB_SPEC["pipelineSpec"]["root"],
},
runtime_config=runtime_config,
service_account=_TEST_SERVICE_ACCOUNT,
network=_TEST_NETWORK,
)

mock_pipeline_service_create.assert_called_once_with(
Expand Down