Skip to content

feat: column specs for tabular transformation - #466

Merged
gcf-merge-on-green[bot] merged 23 commits into
googleapis:masterfrom
sirtorry:tabular_transformations
Jul 15, 2021
Merged

feat: column specs for tabular transformation#466
gcf-merge-on-green[bot] merged 23 commits into
googleapis:masterfrom
sirtorry:tabular_transformations

Conversation

@sirtorry

@sirtorry sirtorry commented Jun 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • adds column_specs as an alternative to column_transformation
  • adds training_jobs.AutoMLTabularTrainingJob.get_auto_column_specs
  • adds aiplatform.column

@sirtorry
sirtorry requested review from a team and ivanmkc June 8, 2021 20:04
@product-auto-label product-auto-label Bot added the api: aiplatform Issues related to the AI Platform API. label Jun 8, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2021
ivanmkc
ivanmkc reviewed Jun 8, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/datasets/tabular_dataset.py Outdated
sirtorry
sirtorry commented Jun 8, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/datasets/tabular_dataset.py Outdated
sirtorry
sirtorry commented Jun 8, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/datasets/time_series_dataset.py Outdated
@sirtorry sirtorry changed the title [WIP] tabular transformation feature feat: column specs for tabular transformation Jun 15, 2021
@sirtorry
sirtorry requested review from ivanmkc and sasha-gitg June 15, 2021 19:53
@sirtorry
sirtorry requested a review from vinnysenthil June 15, 2021 21:21
ivanmkc
ivanmkc suggested changes Jun 16, 2021
View reviewed changes

@ivanmkc ivanmkc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

Comment thread google/cloud/aiplatform/datasets/time_series_dataset.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread tests/unit/aiplatform/test_automl_tabular_training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/column.py Outdated
sasha-gitg
sasha-gitg requested changes Jun 21, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/datasets/time_series_dataset.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread tests/unit/aiplatform/test_automl_tabular_training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py
Comment thread google/cloud/aiplatform/__init__.py Outdated
@sirtorry
sirtorry requested review from ivanmkc and sasha-gitg and removed request for vinnysenthil July 10, 2021 18:31
sasha-gitg
sasha-gitg requested changes Jul 13, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/training_jobs.py
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
ivanmkc
ivanmkc reviewed Jul 13, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/training_jobs.py
ivanmkc
ivanmkc reviewed Jul 13, 2021
View reviewed changes
Comment thread tests/unit/aiplatform/test_automl_tabular_training_jobs.py
ivanmkc
ivanmkc reviewed Jul 13, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/training_jobs.py Outdated
ivanmkc
ivanmkc reviewed Jul 13, 2021
View reviewed changes
Comment thread tests/unit/aiplatform/test_automl_tabular_training_jobs.py
ivanmkc
ivanmkc reviewed Jul 13, 2021
View reviewed changes
Comment thread google/cloud/aiplatform/training_jobs.py
@sirtorry
sirtorry requested review from ivanmkc and sasha-gitg July 14, 2021 22:17
sasha-gitg
sasha-gitg approved these changes Jul 15, 2021
View reviewed changes

@sasha-gitg sasha-gitg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly LGTM. One more comment it seems I didn't include in the last review. Thanks!

Comment thread google/cloud/aiplatform/training_jobs.py Outdated
ivanmkc
ivanmkc approved these changes Jul 15, 2021
View reviewed changes

@ivanmkc ivanmkc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Sasha's suggestion

@ivanmkc

ivanmkc commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

What about the deprecation warning for column_transformations?

@sirtorry sirtorry added the automerge Merge the pull request once unit tests and other checks pass. label Jul 15, 2021
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 71d0bd4 into googleapis:master Jul 15, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 15, 2021
@sirtorry
sirtorry deleted the tabular_transformations branch July 15, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes
+1 more reviewer
@ivanmkc ivanmkc ivanmkc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sirtorry @ivanmkc @sasha-gitg