Skip to content

feat: fully qualified name util#38

Merged
sirtorry merged 12 commits into
googleapis:devfrom
sirtorry:fully_qualified_name_helper
Nov 4, 2020
Merged

feat: fully qualified name util#38
sirtorry merged 12 commits into
googleapis:devfrom
sirtorry:fully_qualified_name_helper

Conversation

@sirtorry
Copy link
Copy Markdown
Contributor

Fixes b/170954330.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2020
@sirtorry
Copy link
Copy Markdown
Contributor Author

hmm i ran black again but nothing changed 🤔

@sirtorry sirtorry added the automerge Merge the pull request once unit tests and other checks pass. label Oct 30, 2020
Copy link
Copy Markdown
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the error messages, looking good!

LGTM

@gcf-merge-on-green gcf-merge-on-green Bot removed automerge Merge the pull request once unit tests and other checks pass. labels Oct 31, 2020
Comment thread google/cloud/aiplatform/utils.py Outdated
Comment thread google/cloud/aiplatform/utils.py Outdated
Comment thread google/cloud/aiplatform/utils.py
Comment thread google/cloud/aiplatform/datasets.py Outdated
Comment thread google/cloud/aiplatform/utils.py Outdated
Comment thread tests/unit/aiplatform/test_utils.py
Comment thread google/cloud/aiplatform/utils.py Outdated
Comment thread google/cloud/aiplatform/utils.py Outdated
@sirtorry sirtorry merged commit 3d47526 into googleapis:dev Nov 4, 2020
@sirtorry sirtorry deleted the fully_qualified_name_helper branch November 4, 2020 19:33
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants