feat: Added create_training_pipeline_custom_job_sample and create_training_pipeline_custom_training_managed_dataset_sample and fixed create_training_pipeline_image_classification_sample#343
Merged
ivanmkc merged 10 commits intoApr 27, 2021
Conversation
chore: merge main into dev
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
85fff2d to
0ca06d5
Compare
… and fixed unmanaged sample
4ea56bf to
68eff56
Compare
sasha-gitg
reviewed
Apr 21, 2021
|
|
||
|
|
||
| # [START aiplatform_sdk_create_and_import_dataset_tabular_bigquery_sample] | ||
| def create_and_import_dataset_tabular_bigquery_sample( |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Yes, but it's under my name. Let me check with @aribray.
Contributor
Author
There was a problem hiding this comment.
The assignments might have changed between her writing the sample and me starting. I will remove these and we can use Ari's.
sasha-gitg
requested changes
Apr 21, 2021
| def create_training_pipeline_custom_job_sample( | ||
| project: str, | ||
| display_name: str, | ||
| args: List[str], |
Member
There was a problem hiding this comment.
args are optional and should default to None.
| script_path: str, | ||
| container_uri: str, | ||
| location: str = "us-central1", | ||
| model_display_name: str = None, |
Member
There was a problem hiding this comment.
Suggested change
| model_display_name: str = None, | |
| model_display_name: Optional[str] = None, |
Contributor
Author
There was a problem hiding this comment.
Could do it, but I followed the example of the existing create_training_pipeline_image_classification_sample. I will change it there too.
| script_path: str, | ||
| container_uri: str, | ||
| location: str = "us-central1", | ||
| model_display_name: str = None, |
Member
There was a problem hiding this comment.
We should also include the model_serving_container_image_uri as required since we are returning the Model in the sample.
| container_uri: str, | ||
| dataset_id: int, | ||
| location: str = "us-central1", | ||
| model_display_name: str = None, |
Member
There was a problem hiding this comment.
Same comments here as above.
Contributor
Author
|
@sasha-gitg I fixed a couple other things along the same lines, such as order of args. |
22abd8c to
fec3e6c
Compare
sasha-gitg
approved these changes
Apr 22, 2021
Contributor
Author
|
@dinagraves Linting fixed. Can I get another look? I usually run the linter after all the other checks/approvals pass so I only run it once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 2 samples with tests:
Fixed: