Add initial helper util functions and tests#25
Merged
Conversation
sasha-gitg
approved these changes
Oct 7, 2020
Member
sasha-gitg
left a comment
There was a problem hiding this comment.
Looks good! Couple of high level comments:
-
I don't think all services only accept integer strings as the resource ids. Capture this in a ticket and add a comment "TODO(b/...) ... "
-
There may be nested resource names as well, not just one level. Capture that as a ticket and comment.
Thanks!
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Add initial helper util functions and tests * Make requested changes, add TODOs to utils.py * Fix indent and lint
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Add initial helper util functions and tests * Make requested changes, add TODOs to utils.py * Fix indent and lint
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Add initial helper util functions and tests * Make requested changes, add TODOs to utils.py * Fix indent and lint
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Add initial helper util functions and tests * Make requested changes, add TODOs to utils.py * Fix indent and lint
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Add initial helper util functions and tests * Make requested changes, add TODOs to utils.py * Fix indent and lint
dizcology
pushed a commit
to dizcology/python-aiplatform
that referenced
this pull request
Dec 22, 2020
* Add initial helper util functions and tests * Make requested changes, add TODOs to utils.py * Fix indent and lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a
utils.pymodule containing two helper functions:get_client_options— Returns aclient_optionsdict based on location set by intializer or override and whether the client is for prediction .validate_name— Validates an fully-qualified AI Platform resource name and returns the contained values as properties of a tuple subclass.Please take a look at the tests for more usage.