Skip to content

GAPIC namespace#20

Merged
dizcology merged 3 commits into
googleapis:masterfrom
dizcology:gapic-namespace1
Oct 2, 2020
Merged

GAPIC namespace#20
dizcology merged 3 commits into
googleapis:masterfrom
dizcology:gapic-namespace1

Conversation

@dizcology
Copy link
Copy Markdown
Contributor

@dizcology dizcology commented Oct 2, 2020 •
edited
Loading

DO NOT MERGE until confirmed about the approach.

Current user code (which will be broken after this change):

from google.cloud import aiplatform
dataset = aiplatform.Dataset(...)

Expected user code after this change:

from google.cloud import aiplatform
dataset = aiplatform.gapic.Dataset(...)
# also works: dataset = aiplatform.gapic.v1beta1.Dataset(...)

@dizcology dizcology added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 2, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
@dizcology dizcology merged commit 7e83ff6 into googleapis:master Oct 2, 2020
sasha-gitg added a commit that referenced this pull request Oct 5, 2020
@sasha-gitg @dizcology
Updating dev with module namespace changes. (#21)
ba60ed3 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
busunkim96 added a commit that referenced this pull request Oct 20, 2020
@busunkim96 @dizcology @vinnysenthil
chore: update dev with changes to master (#33)
e43bee1 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (#28)

* clean up docstrings that are not rendered properly in reference doc (#24)

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

* fix: re-add py sessions to noxfile (#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@busunkim96 @dizcology @vinnysenthil
chore: update dev with changes to master (googleapis#33)
6958de8 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (googleapis#28)

* clean up docstrings that are not rendered properly in reference doc (googleapis#24)

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

* fix: re-add py sessions to noxfile (googleapis#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sasha-gitg @dizcology
Updating dev with module namespace changes. (googleapis#21)
93feaf9 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sasha-gitg @dizcology
Updating dev with module namespace changes. (googleapis#21)
3b4a7bb 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@sasha-gitg @dizcology
Updating dev with module namespace changes. (googleapis#21)
6913937 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology added a commit to dizcology/python-aiplatform that referenced this pull request Nov 30, 2020
@busunkim96 @dizcology @vinnysenthil
chore: update dev with changes to master (googleapis#33)
83b2b9a 
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17)

Freeing up the google.cloud.aiplatform namespace for MB SDK

* GAPIC namespace (googleapis#20)

* name space google.cloud.aiplatform.gapic

* Init Disclaimer (googleapis#28)

* clean up docstrings that are not rendered properly in reference doc (googleapis#24)

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

* fix: re-add py sessions to noxfile (googleapis#22)

* fix: re-add py sessions to noxfile

Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>

Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@telpirion telpirion Awaiting requested review from telpirion

@sirtorry sirtorry Awaiting requested review from sirtorry

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@vinnysenthil vinnysenthil vinnysenthil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dizcology @vinnysenthil