Skip to content

chore: refactor model monitoring system test to make it more efficient#1624

Merged
rosiezou merged 4 commits into
mainfrom
mm-sys-test-refactor
Aug 31, 2022
Merged

chore: refactor model monitoring system test to make it more efficient#1624
rosiezou merged 4 commits into
mainfrom
mm-sys-test-refactor

Conversation

@rosiezou
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #244334087 🦕

@rosiezou rosiezou requested review from a team and dizcology August 31, 2022 06:13
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Aug 31, 2022
@rosiezou rosiezou self-assigned this Aug 31, 2022
@rosiezou rosiezou changed the title Mm sys test refactor chore: refactor model monitoring system test to make it more efficient Aug 31, 2022
Copy link
Copy Markdown
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rosiezou rosiezou merged commit 6bafca5 into main Aug 31, 2022
@rosiezou rosiezou deleted the mm-sys-test-refactor branch August 31, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants