Skip to content

feat: Added predict schemata support to Model.upload#100

Merged
ivanmkc merged 2 commits into
googleapis:devfrom
ivanmkc:imkc--predict-schemata
Dec 2, 2020
Merged

feat: Added predict schemata support to Model.upload#100
ivanmkc merged 2 commits into
googleapis:devfrom
ivanmkc:imkc--predict-schemata

Conversation

@ivanmkc
Copy link
Copy Markdown
Contributor

@ivanmkc ivanmkc commented Dec 1, 2020

Added predict schemata support to Model.upload.

Fixes https://b.corp.google.com/issues/170979552

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2020
@ivanmkc ivanmkc requested a review from sasha-gitg December 1, 2020 18:26
@ivanmkc
Copy link
Copy Markdown
Contributor Author

ivanmkc commented Dec 1, 2020

@sasha-gitg this is my best guess at what the feature requirements are.

@dizcology mentioned that that the URI's aren't actually used? If so, then should we note that in the doc strings so users don't waste time debugging them if something goes wrong?

@ivanmkc ivanmkc force-pushed the imkc--predict-schemata branch from a494721 to a5bdfb7 Compare December 1, 2020 18:31
Copy link
Copy Markdown
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanmkc ivanmkc merged commit 2ca6342 into googleapis:dev Dec 2, 2020
dizcology pushed a commit to dizcology/python-aiplatform that referenced this pull request Dec 22, 2020
Co-authored-by: Ivan Cheung <ivanmkc@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants