Skip to content

fix: update BucketInfo translation code to properly handle lifecycle rules #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenWhitehead merged 4 commits into from
Jun 1, 2021
Merged

fix: update BucketInfo translation code to properly handle lifecycle rules #852

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76a82cc
fix: update BucketInfo translation code to properly handle lifecycle …
BenWhitehead May 27, 2021
13f79a5
update handling of rules to ensure removal of rules is correctly acco…
BenWhitehead May 27, 2021
c39b188
bow to the all mighty formatter *bow*
BenWhitehead May 27, 2021
38b2abc
add comment
BenWhitehead Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1862,7 +1862,7 @@ public Rule apply(LifecycleRule lifecycleRule) {
}));
}

if (rules != null) {
if (!rules.isEmpty()) {
Comment thread
BenWhitehead marked this conversation as resolved.
Outdated
Lifecycle lifecycle = new Lifecycle();
lifecycle.setRule(ImmutableList.copyOf(rules));
bucketPb.setLifecycle(lifecycle);
Expand Down