Skip to content

feat: integrate disable Lifecycle rule api for to remove lifecycle rule of bucket #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
athakor wants to merge 21 commits into from
Closed

feat: integrate disable Lifecycle rule api for to remove lifecycle rule of bucket #28

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a73af3e
feat: integrate disabling Lifecycle rule api for to removing lifecycl…
athakor Dec 31, 2019
22351d8
feat: code refactor and added method level java doc with example
athakor Jan 3, 2020
2332a13
feat: add unit test and resolve used undeclared dependencies warnings
athakor Jan 3, 2020
e1bc3ab
feat: fix methods name
athakor Jan 6, 2020
42c932c
feat: fix formatter and fix method name in unit test
athakor Jan 6, 2020
f635369
feat: all the notes has been resolved
athakor Jan 8, 2020
bd15eed
build: ignore clirr related errors
athakor Jan 9, 2020
32a716e
fix: fix review changes
athakor Jan 16, 2020
1e4b71c
feat: use default service account to generate accesstoken
athakor Jan 18, 2020
affa5e1
build: fix unused declared dependencies
athakor Jan 18, 2020
08e5c39
feat: use defaul service account creadential and add testcase for del…
athakor Feb 3, 2020
5918c7e
feat: modified the code
athakor Feb 3, 2020
398a771
build: fix windows related builds
athakor Feb 3, 2020
d48d6b6
fix: resolve conflicts
athakor Feb 7, 2020
9e4d3fe
build: fix deps build
athakor Feb 7, 2020
57045a3
feat: code refactoring
athakor Feb 21, 2020
dd3a276
feat: uncomment the prepareKmsKeys
athakor Feb 21, 2020
f722f70
feat: update method name in HttpStorageRpcSpans and remove unused code
athakor Feb 21, 2020
4d273fe
feat: fix the typos
athakor Feb 27, 2020
c3b1e81
fix: review changes
athakor Apr 23, 2020
6a9da63
build: fix lint error
athakor May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: fix formatter and fix method name in unit test
  • Loading branch information
@athakor
athakor committed May 18, 2020
commit 42c932cb5424685789e69d1f86d450ff4e11f98a
2 changes: 0 additions & 2 deletions google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2010,8 +2010,6 @@ Blob create(
* BlobId blobId = BlobId.of(bucketName, blobName);
* Blob blob = storage.get(blobId, BlobGetOption.decryptionKey(blobEncryptionKey));
* }</pre>
*
* @throws StorageException upon failure
*/
Blob get(BlobId blob, BlobGetOption... options);

Expand Down
4 changes: 2 additions & 2 deletions google-cloud-storage/src/test/java/com/google/cloud/storage/BucketTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,10 +706,10 @@ public void testDeleteDefaultAcl() throws Exception {
@Test
public void testDisableLifeCycleRule() {
expect(storage.getOptions()).andReturn(mockOptions).times(1);
expect(storage.disableLifeCycleRule(BUCKET_INFO.getName(), "clientEmail")).andReturn(true);
expect(storage.disableLifeCycleRules(BUCKET_INFO.getName(), "clientEmail")).andReturn(true);
replay(storage);
initializeBucket();
assertTrue(bucket.disableLifeCycleRule(BUCKET_INFO.getName(), "clientEmail"));
assertTrue(bucket.disableLifeCycleRules(BUCKET_INFO.getName(), "clientEmail"));
}

@Test
Expand Down