Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

test: split tests by resource type. fix query time by limiting by timestamp - #225

Merged
chingor13 merged 3 commits into
masterfrom
deflake
Sep 1, 2020
Merged

test: split tests by resource type. fix query time by limiting by timestamp#225
chingor13 merged 3 commits into
masterfrom
deflake

Conversation

@chingor13

@chingor13 chingor13 commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

This should reduce the time for the integration tests from ~20 minutes to ~5 minutes and should prevent the tests from timing out.

  • This PR breaks the monolilthic IT test file into tests by scope (java.util.Logger implementation, metrics, sinks, and direct logging client use).
  • Previously, all the tests were defined in the BaseSystemTest with a single implementation which didn't seem necessary. Now the base class has shared helper functionality for fetching logs and instantiating the logging client.
  • When fetching logs, we now only look at timestamps > 1 hour ago. This speeds up the list queries from 2 minutes to seconds.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2020
@chingor13

Copy link
Copy Markdown
Contributor Author

ListSink tests fixed in #226

@chingor13
chingor13 requested a review from a team September 1, 2020 21:12
@chingor13
chingor13 merged commit d431ea4 into master Sep 1, 2020
@chingor13
chingor13 deleted the deflake branch September 1, 2020 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants