fix: ChatBase constructor ignores history parameters#783
Closed
jonasstenberg wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The ChatBase constructor was ignoring its parameters and always initializing comprehensiveHistory and curatedHistory as empty lists. This prevented any pre-existing conversation history from being used.
7c03e19 to
c78d473
Compare
jaycee-li
approved these changes
Feb 25, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
-- c78d473 by Jonas Stenberg <js@squidler.io>: fix: initialize comprehensive and curated history in constructor The ChatBase constructor was ignoring its parameters and always initializing comprehensiveHistory and curatedHistory as empty lists. This prevented any pre-existing conversation history from being used. COPYBARA_INTEGRATE_REVIEW=#783 from jonasstenberg:patch-1 c78d473 PiperOrigin-RevId: 875404679
Collaborator
|
Your PR has been submitted in f74a426, so this one will be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ChatBaseconstructor acceptscomprehensiveHistoryandcuratedHistoryparameters but never uses them—both fields are always initialized as emptyArrayListinstances regardless of what's passed in.The Bug
The Fix
Impact
This bug would prevent any functionality that relies on initializing a chat session with existing conversation history from working correctly.