Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: remove unused throws from test methods#214

Merged
BenWhitehead merged 1 commit into
googleapis:masterfrom
suraj-qlogic:firestore-remove-throws
May 13, 2020
Merged

chore: remove unused throws from test methods#214
BenWhitehead merged 1 commit into
googleapis:masterfrom
suraj-qlogic:firestore-remove-throws

Conversation

@suraj-qlogic
Copy link
Copy Markdown
Contributor

Fixes #212

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2020
@suraj-qlogic suraj-qlogic added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2020

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #214   +/-   ##
=========================================
  Coverage     72.69%   72.69%           
  Complexity     1000     1000           
=========================================
  Files            63       63           
  Lines          5304     5304           
  Branches        600      600           
=========================================
  Hits           3856     3856           
  Misses         1260     1260           
  Partials        188      188           
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/firestore/Query.java 91.13% <94.73%> (ø) 105.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b376003...d059c05. Read the comment docs.

@suraj-qlogic suraj-qlogic requested a review from BenWhitehead May 13, 2020 06:30
@BenWhitehead BenWhitehead merged commit 81c20c5 into googleapis:master May 13, 2020
@suraj-qlogic suraj-qlogic deleted the firestore-remove-throws branch May 15, 2020 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary throws declarations from test

4 participants