fix: update client header to use <h3> instead of <h2>#179
Merged
Conversation
Member
|
@alicejli : Can you clarify which doc-pipeline template file is going to be modified in part 2? |
Contributor
Author
@burkedavison This is the PR that updates doc-pipeline: googleapis/doc-pipeline#439. I ended up adding a new template for Java Overviews specifically. Note that it fails the golden tests right now and @dandhlee is helping me look into how to update the goldens as the instructions don't currently work for my setup for some reason. |
burkedavison
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178 (part 1 of full fix)
Part 2 of fix: googleapis/doc-pipeline#436