Closed
Conversation
The options file used by real Javadoc tool has single quotes for the values.
lqiu96
commented
Jul 20, 2022
Comment on lines
+24
to
+25
| this.globalLookup = new HashMap<>(INITIAL_CAPACITY); | ||
| this.localLookupByFileName = new HashMap<>(INITIAL_CAPACITY); |
Member
Author
There was a problem hiding this comment.
Set a large initial capacity to try and reduce the number of copying done (capacity expansion)
lqiu96
commented
Jul 20, 2022
Comment on lines
+24
to
+25
| private final Map<Element, List<? extends Element>> elementMap; | ||
| private final Map<Element, List<TypeElement>> elementSortedMap; |
Member
Author
There was a problem hiding this comment.
Create map to cache the element and the results from getEnclosedElements(). From what I see, most of the slowdown is from element.getEnclosedElement().
lqiu96
commented
Jul 20, 2022
Comment on lines
-83
to
-86
| for (int i = 0; i < generatedFileLines.length; i++) { | ||
| assertEquals("Wrong file content for file " + generatedFilePath, | ||
| generatedFileLines[i], expectedFileLines[i]); | ||
| } |
Member
Author
There was a problem hiding this comment.
This portion of the test is removed because with adding concurrency we can't guarantee the ordering of the content in the resulting YML files. Perhaps we can figure out a different way to validate the contents of the YML files.
Member
Author
|
Having some concurrency issues. Might need to break out the changes with the Element cache and increase storage for existing caches into a separate PR |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126