Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

chore: renaming transactionId to setTransactionId to increase readability#1041

Closed
jainsahab wants to merge 2 commits into
googleapis:mainfrom
jainsahab:chore_set_transaction_id_rename
Closed

chore: renaming transactionId to setTransactionId to increase readability#1041
jainsahab wants to merge 2 commits into
googleapis:mainfrom
jainsahab:chore_set_transaction_id_rename

Conversation

@jainsahab
Copy link
Copy Markdown
Contributor

addressing #823 (comment)

@jainsahab jainsahab requested review from a team April 4, 2023 13:59
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Apr 4, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Apr 4, 2023
@jainsahab jainsahab mentioned this pull request Apr 4, 2023
@jainsahab jainsahab requested a review from a team April 4, 2023 14:06
@kolea2
Copy link
Copy Markdown
Contributor

kolea2 commented Apr 17, 2023

Looking at this again, I didn't notice the other methods in the class are also missing the set... prefix. I suppose it makes more sense to be consistent. Sorry for the back and forth, I'll close this out and the issue.

@kolea2 kolea2 closed this Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants