chore: update DirectPath tests#347
Merged
kolea2 merged 5 commits intogoogleapis:masterfrom Jul 6, 2020
Merged
Conversation
…ar; Change fallback tests to blackhole all ipv4 and ipv6 DP addresses
kolea2
reviewed
Jun 16, 2020
igorbernstein2
requested changes
Jun 16, 2020
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
Looks great, but please address the comments
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Outdated
Show resolved
Hide resolved
...-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/DirectPathFallbackIT.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
============================================
+ Coverage 80.69% 80.75% +0.06%
- Complexity 1049 1050 +1
============================================
Files 99 99
Lines 6541 6536 -5
Branches 344 341 -3
============================================
Hits 5278 5278
+ Misses 1082 1078 -4
+ Partials 181 180 -1
Continue to review full report at Codecov.
|
stephaniewang526
approved these changes
Jun 22, 2020
Contributor
Author
|
Hi Igor and Stephanie, I'm seeing failure in CI windows build: Any thoughts? Edit: it seems passed, NVM :) |
Contributor
Author
|
@igorbernstein2 : I have additionally updated the directpath test endpoint to be the JZ one: "testdirectpath-bigtable.sandbox.googleapis.com:443", as DirectPath ipv4 support will be initially enabled in JZ. PTAL, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q: This change depends on v0.8.0 google-cloud-shared-dependencies, so do I need to wait for #338 to be merged?