Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

test: reduce test noise - #2257

Merged
igorbernstein2 merged 3 commits into
mainfrom
test-noise
Jun 12, 2024
Merged

test: reduce test noise#2257
igorbernstein2 merged 3 commits into
mainfrom
test-noise

Conversation

@igorbernstein2

@igorbernstein2 igorbernstein2 commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
test: reduce noise by properly closing stubs
5a3a0d9 
Change-Id: I50f954be0d6a0c5b4db6377e3403c81f3b14a167
@igorbernstein2
test: fix some of the noise during builds and test runs
27c5376 
- make sure to close stubs to avoid grpc warnings
- add missing plugin versions
- fix deprecated syntax in pom.xml
- filter out useless "Connecting to the Bigtable emulator..." log lines
- configure logs to be on a single line

Change-Id: Iacbd41c953ef0f3f726ef041dde0093d8bc2c6e6
@igorbernstein2
igorbernstein2 requested review from a team June 11, 2024 17:13
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 11, 2024
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 11, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@igorbernstein2
cleanup
c9ed746 
Change-Id: I6cbd1c5d194112c7587f58337d7a810f81375ba7
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@igorbernstein2
igorbernstein2 merged commit eea4eb0 into main Jun 12, 2024
@igorbernstein2
igorbernstein2 deleted the test-noise branch June 12, 2024 15:59
ron-gal pushed a commit to ron-gal/java-bigtable that referenced this pull request Jul 23, 2024
@igorbernstein2 @ron-gal
test: reduce test noise (googleapis#2257)
e942ec9 
* test: reduce noise by properly closing stubs

Change-Id: I50f954be0d6a0c5b4db6377e3403c81f3b14a167

* test: fix some of the noise during builds and test runs

- make sure to close stubs to avoid grpc warnings
- add missing plugin versions
- fix deprecated syntax in pom.xml
- filter out useless "Connecting to the Bigtable emulator..." log lines
- configure logs to be on a single line

Change-Id: Iacbd41c953ef0f3f726ef041dde0093d8bc2c6e6

* cleanup

Change-Id: I6cbd1c5d194112c7587f58337d7a810f81375ba7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@rkaregar rkaregar rkaregar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2 @rkaregar @yoshi-kokoro