This repository was archived by the owner on Mar 23, 2026. It is now read-only.
ci: not to check flatten plugin behavior#2391
Merged
Merged
Conversation
We have had the check for the flatten-maven-plugin in each Cloud Java client repository. However, the behavior of the plugin has been stable and its not each repository's responsibility to assert the plugin's behavior. A new check has added at the googleapis/java-shared-config repository to assert the plugin's behavior when we upgrade its version.
suztomo
commented
Nov 1, 2022
| java.common_templates(excludes=[ | ||
| '.kokoro/nightly/samples.cfg', | ||
| '.kokoro/presubmit/samples.cfg', | ||
| '.kokoro/dependencies.sh', |
Member
Author
There was a problem hiding this comment.
Why was this file excluded? It's because we had to add exclusions specific to this repository https://github.com/googleapis/java-bigquery/pull/1266/files#diff-567d21712b8e585cfcb63e34de4bf9e8aa76df9c564ae6caa769051752898cd6R55
Neenu1995
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have had the check for the flatten-maven-plugin in each Cloud Java client repository. However, the behavior of the plugin has been stable and its not each repository's responsibility to assert the plugin's behavior. A new check has added at the googleapis/java-shared-config repository to assert the plugin's behavior when we upgrade its version (googleapis/java-shared-config#530)