Skip to content

fix: revert the order of stream closure and disconnect#1427

Merged
chanseokoh merged 1 commit into
masterfrom
i1409-disconnect-revert-i1303
Sep 23, 2021
Merged

fix: revert the order of stream closure and disconnect#1427
chanseokoh merged 1 commit into
masterfrom
i1409-disconnect-revert-i1303

Conversation

@chanseokoh

@chanseokoh chanseokoh commented Aug 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1409 ☕️

I don't know how exactly #1303 should be resolved, but given the critical nature of #1409, we should revert #1315 now.

@chanseokoh chanseokoh requested a review from a team August 17, 2021 20:44
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@chanseokoh chanseokoh mentioned this pull request Aug 23, 2021
Closed
@chanseokoh

chanseokoh commented Aug 27, 2021

Copy link
Copy Markdown
Contributor Author

@chingor13

@lesv

lesv commented Sep 22, 2021 •
edited by chanseokoh
Loading

Copy link
Copy Markdown
Contributor

Ping - @chanseokoh Since it's been almost a month, could you confirm what you want to want (and in what order) you want them to happen here? I see:

  • revert 1315
  • merge this PR

@lesv

lesv commented Sep 22, 2021 •
edited by chanseokoh
Loading

Copy link
Copy Markdown
Contributor

It looks like you are reverting a test from #1315 - so do you still need the whole PR reverted?

@chanseokoh

chanseokoh commented Sep 23, 2021

Copy link
Copy Markdown
Contributor Author

@lesv you mean #1315, not #1305, right? I am not commit-reverting it, since #1315 has some other refactoring stuff we want to keep. This PR just reverts what's necessary, i.e, the order of stream closure and disconnect. Merging this PR will make everything right.

@chanseokoh chanseokoh merged commit c21e745 into master Sep 23, 2021
@chanseokoh chanseokoh deleted the i1409-disconnect-revert-i1303 branch September 23, 2021 14:21
@famod famod mentioned this pull request Oct 3, 2021
Closed
@chanseokoh chanseokoh changed the title Revert the order of stream closure and disconnect fix: revert the order of stream closure and disconnect Oct 3, 2021
@rarsan rarsan mentioned this pull request Oct 29, 2021
Closed
@Animeshz

Animeshz commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Hey, this is causing full reads in hadoop-gcs-connector for files that is opened for reading just a few bytes. It drains the whole connection which is opened to the EOF (GoogleCloudDataproc/hadoop-connectors#1729).

Can we discuss the possible fixes instead of revert and ignoring the issue (#1303)?

@Animeshz Animeshz mentioned this pull request Jun 18, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Premature end of chunk coded message body" and TruncatedChunkException when calling HttpResponse.disconnect()

3 participants

@chanseokoh @lesv @Animeshz