feat(pubsub): Support subscriber shutdown options - #36480
Open
aandreassa wants to merge 1 commit into
Open
Conversation
aandreassa
changed the base branch from
main
to
pubsub-shutdown-stream-inventory
August 28, 2026 00:13
aandreassa
force-pushed
the
pubsub-shutdown-options
branch
from
August 28, 2026 00:38
d9a60e0 to
0569232
Compare
aandreassa
marked this pull request as ready for review
August 28, 2026 16:54
torreypayne
approved these changes
Aug 28, 2026
Supports `:shutdown_behavior` and `:shutdown_timeout` options when listening for messages on a subscriber: 1. Added `shutdown_behavior:` (`:wait_for_processing`, `:nack_immediately`) and `shutdown_timeout:` arguments to `Subscriber#listen` and `MessageListener.new`. 2. Added parameter validation for shutdown options in `MessageListener`. 3. Coordinated stream stop and inventory wait across streams in `MessageListener#stop!` and `#wait!`. 4. Added unit tests in `message_listener_test.rb` and `listen_test.rb`. 5. Added end-to-end acceptance tests in `async_test.rb` verifying live `:nack_immediately` and `:wait_for_processing` behaviors.
aandreassa
force-pushed
the
pubsub-shutdown-options
branch
from
August 28, 2026 21:58
0569232 to
79c3595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports
:shutdown_behaviorand:shutdown_timeoutoptions when listening for messages on a subscriber:shutdown_behavior:(:wait_for_processing,:nack_immediately) andshutdown_timeout:arguments toSubscriber#listenandMessageListener.new.MessageListener.MessageListener#stop!and#wait!.message_listener_test.rbandlisten_test.rb.async_test.rbverifying live:nack_immediatelyand:wait_for_processingbehaviors.