chore: Migrate samples to google-cloud-pubsub v3#30618
Merged
Merged
Conversation
d0ae18f to
72ce692
Compare
dazuma
suggested changes
Jul 15, 2025
|
|
||
| subscription_admin = pubsub.subscription_admin | ||
|
|
||
| subscription = subscription_admin.create_subscription name: pubsub.subscription_path(subscription_id), |
Contributor
There was a problem hiding this comment.
We should try to limit actual samples to 80 columns so they show up well on the web page without requiring excessive horizontal scrolling. This might mean formatting method calls with these long names differently. For example, you could either:
subscription = subscription_admin.create_subscription(
name: pubsub.subscription_path(subscription_id),
topic: pubsub.topic_path(topic_id),
bigquery_config: {
table: bigquery_table_id,
write_metadata: true
}
)or sometimes we've done:
subscription = subscription_admin.create_subscription \
name: pubsub.subscription_path(subscription_id),
topic: pubsub.topic_path(topic_id),
bigquery_config: {
table: bigquery_table_id,
write_metadata: true
}
Contributor
Author
There was a problem hiding this comment.
Updated a bunch of them to follow it. FYI I added second commit for s/Pubsub/PubSub/g module name in the samples directory.
Contributor
Author
|
Those sample test cases are somewhat flaky. It passes locally consistently. |
Contributor
Author
|
Misclicked to close PR. Merging! |
shubhangi-google
pushed a commit
to shubhangi-google/google-cloud-ruby
that referenced
this pull request
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.