Add documentation for enabling gRPC logging#2094
Conversation
|
@blowmage I tried setting the logger as you suggested in #1907, but I got this warning: irb(main):006:0> GRPC::DefaultLogger::LOGGER = my_logger
(irb):6: warning: already initialized constant GRPC::DefaultLogger::LOGGERSo instead I adapted the suggested example in the gRPC spec_helper.rb. It works, but can anyone suggest a simplification? |
blowmage
left a comment
There was a problem hiding this comment.
This works for me.
The only change I’d offer is to link to the Logger docs for the current Ruby version, which is 2.5.
|
I agree it should not be as difficult as it is to set a custom Logger. Ideally it should be simply: GRPC.logger = my_logger |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ddd0321 to
9d8a33b
Compare
|
@dazuma Updated, PTAL. |
|
Thanks for approving, I will copy this change to the READMEs (and "guide" docs where appropriate) for all gRPC packages, then ping for a second look. |
29c75a8 to
7f25c70
Compare
|
@jbolinger PTAL at the commit for generated packages. Does this addition look ok? If so, can it also be added in the generator? Should I open an issue in googleapis/gapic-generator? |
|
@quartzmo looks good! Feel free to open an issue there for this or any other changes you think might be useful. This one looks like it's just static text for each client. Adding it to the generator should be no problem. |
|
@jbolinger I opened googleapis/gapic-generator#2022, "Ruby: Add logging configuration instructions to README and guide docs". |
7f25c70 to
fdbedb2
Compare
|
@jbolinger PTAL, I just added two commits, for changes we discussed in googleapis/gapic-generator#2022 :
|
|
@quartzmo why did you move the version section above the next steps? I thought we said below and at |
|
Ah, sorry, I didn't understand. I did it because in a number of the generated READMEs, such as in dataproc for example it is above Next Steps. So, I thought it must be need to be there. However, I'm happy to move it down as in your gist. Will update. |
Add documentation for enabling gRPC logging. [refs googleapis#1907]
Add documentation for enabling gRPC logging. [refs googleapis#1907]
Add documentation for enabling gRPC logging. [closes googleapis#1907]
Move logging docs below Next Steps in READMEs and guides. [refs googleapis#1907]
Add Supported Ruby Versions above Next Steps in READMEs if missing. [refs googleapis#1907]
fdbedb2 to
3371402
Compare
3371402 to
846eb52
Compare
|
@jbolinger Updated, PTAL. I will squash commits before merging. |
|
@quartzmo looks good! |
[closes #1907]