Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

Prep 0.30.2 release.#41

Merged
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:prep-0.30.1-release
Oct 5, 2018
Merged

Prep 0.30.2 release.#41
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:prep-0.30.1-release

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Sep 13, 2018

Closes #38.

@tseaver tseaver requested a review from sduskis September 13, 2018 17:38
@sduskis
Copy link
Copy Markdown

sduskis commented Sep 13, 2018

@tseaver, I think we ought to hold off upgrading until we fix googleapis/google-cloud-python#5876

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 13, 2018
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Sep 13, 2018

@sduskis OK.

@tseaver
Target 0.30.2 instead.
0ebf25b 
With dependency on 'google-cloud-bigtable==0.30.2'.
@tseaver tseaver changed the title Prep 0.30.1 release. Prep 0.30.2 release. Sep 19, 2018
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 19, 2018
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Sep 19, 2018

@sduskis PTAL: I've updated to require google-cloud-bigtable>=0.30.2,<0.31dev, and bumped the version here to match.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2018
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Sep 21, 2018

@sduskis I added a changelog entry for PR #42, which I just merged. PTAL.

@Froskekongen
Copy link
Copy Markdown

Froskekongen commented Sep 24, 2018

@tseaver: Is the requirement of <0.31dev in setup.py strictly necessary?
@sduskis: Can you approve this PR, so that a new release on pypi becomes available?

@Froskekongen
Copy link
Copy Markdown

Froskekongen commented Oct 1, 2018

In connection.py it seems that instance.copy() is still being used. Isn't this deprecated behaviour?

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Oct 1, 2018

@Froskekongen

Is the requirement of <0.31dev in setup.py strictly necessary?

Until google-cloud-bigtable has a release at GA status, breaking changes are possible (even likely). We therefore need to make a new release of google-cloud-happybase for pretty much any non-patch release of google-cloud-bigtable.

@tseaver tseaver mentioned this pull request Oct 1, 2018
Closed
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Oct 1, 2018

@Froskekongen

In connection.py it seems that instance.copy() is still being used. Isn't this deprecated behaviour?

Thanks for the catch! Tracked in #46.

@tseaver tseaver mentioned this pull request Oct 3, 2018
Merged
@sduskis
Updating changlog
00a6544 
Updating the changelog to include PR #44, and also use the new releasetool format to refer to PR urls.
@sduskis
Copy link
Copy Markdown

sduskis commented Oct 4, 2018

@tseaver, I updated the changelog to include issue #44, and update the PR references to include URLs as per the newer versions of releasetool.

@tseaver tseaver merged commit 78f575b into googleapis:master Oct 5, 2018
@tseaver tseaver deleted the prep-0.30.1-release branch October 5, 2018 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @sduskis @Froskekongen @googlebot