Pub/Sub: update docstrings for client kwargs and fix return types uris#9037
Merged
Conversation
plamut
reviewed
Aug 16, 2019
plamut
left a comment
Contributor
There was a problem hiding this comment.
Do we want to mention client_config kwarg in subscriber client's docstring as well for consistency?
Apart of that it looks good, just please fix some redundant whitespace in the docstrings to make the linter happy.
Contributor
Author
|
Thanks @plamut! Unlike publish with retry settings, for subscriber client, we don't expose retry settings in |
plamut
approved these changes
Aug 18, 2019
plamut
left a comment
Contributor
There was a problem hiding this comment.
Looks good, and thanks for the additional cleanup.
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
googleapis#9037) * Update kwargs docs * lint * Fix return object type * Put back changes in setup.cfg and noxfile.py * fix no new line * fix various return types uris
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
#9037) * Update kwargs docs * lint * Fix return object type * Put back changes in setup.cfg and noxfile.py * fix no new line * fix various return types uris
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show examples of how to create
Fix return types for
publish(),from_service_account_file(),list_topics(),list_topic_subscriptions()subscribe(),from_service_account_file(),list_subscriptions(),list_snapshots()