Repository navigation
Conversation
This is a workaround for a possible regression in pyarrow handling of NaN vs NULL in float columns.
tseaver
approved these changes
Jul 25, 2019
tseaver
left a comment
Contributor
There was a problem hiding this comment.
Do we need an open issue to remind us to revert this change when PyArrow releases a fix?
tseaver
suggested changes
Jul 25, 2019
tseaver
left a comment
Contributor
There was a problem hiding this comment.
We need to pin for unit tests, particularly.
Contributor
Author
|
Found some documentation about this behavior: https://arrow.apache.org/docs/python/data.html#none-values-and-nan-handling Since we are converting from pandas (which uses NaN as a placeholder for NULL for numpy reasons), this behavior is expected. I'll open a new PR that updates the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for a possible regression in pyarrow handling of NaN vs
NULL in float columns.