Skip to content

Pubsub: Use kwargs in test_subscriber_client#8414

Merged
plamut merged 2 commits into
googleapis:masterfrom
dgorelik:master
Jun 19, 2019
Merged

Pubsub: Use kwargs in test_subscriber_client#8414
plamut merged 2 commits into
googleapis:masterfrom
dgorelik:master

Conversation

@dgorelik

Copy link
Copy Markdown
Contributor

This prevents test failures in case the ordering of the keyword arguments to the StreamingPullManager.open is switched

dgorelik added 2 commits June 18, 2019 12:56
This prevents test failures in case the ordering of the keyword arguments to the `StreamingPullManager.open` is switched
Use kwargs in test_subscriber_client
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
@tseaver tseaver changed the title Use kwargs in test_subscriber_client Pubsub: Use kwargs in test_subscriber_client Jun 18, 2019

@plamut plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@plamut plamut merged commit 126474c into googleapis:master Jun 19, 2019
parthea pushed a commit that referenced this pull request Mar 2, 2026
This prevents test failures in case the ordering of the keyword arguments to the `StreamingPullManager.open` is switched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants