Skip to content

Trace: Declare encoding as utf-8 in pb2 files (via synth). #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 3 commits into from
Jun 17, 2019
Merged

Trace: Declare encoding as utf-8 in pb2 files (via synth). #8368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b54126c
[CHANGE ME] Re-generated trace to pick up changes in the API or clien…
yoshi-automation Jun 15, 2019
c35185a
Source encoding header is correctly generated.
busunkim96 Jun 17, 2019
f568b1a
Regenerate.
busunkim96 Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion trace/.coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# Generated by synthtool. DO NOT EDIT!
[run]
branch = True

Expand Down
1 change: 0 additions & 1 deletion trace/.flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# Generated by synthtool. DO NOT EDIT!
[flake8]
ignore = E203, E266, E501, W503
exclude =
Expand Down
1 change: 0 additions & 1 deletion trace/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# Generated by synthtool. DO NOT EDIT!
[bdist_wheel]
universal = 1
10 changes: 5 additions & 5 deletions trace/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-06-14T12:35:05.147762Z",
"updateTime": "2019-06-17T16:55:18.612177Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.25.0",
"dockerImage": "googleapis/artman@sha256:ef1a98ab1e2b8f05f4d9a56f27d63347aefe14020e5f2d585172b14ca76f1d90"
"version": "0.26.0",
"dockerImage": "googleapis/artman@sha256:6db0735b0d3beec5b887153a2a7c7411fc7bb53f73f6f389a822096bd14a3a15"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "c23b68eecb00c4d285a730a49b1d7d943cd56183",
"internalRef": "253113405"
"sha": "7b58b37559f6a5337c4c564518e9573d742df225",
"internalRef": "253322136"
}
},
{
Expand Down
4 changes: 0 additions & 4 deletions trace/synth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
# Copy docs configuration
s.move(library / f"docs/conf.py")

# Issues exist where python files should define the source encoding
# https://github.com/googleapis/gapic-generator/issues/2097
s.replace("google/**/proto/*_pb2.py", r"(^.*$\n)*", r"# -*- coding: utf-8 -*-\n\g<0>")

# ----------------------------------------------------------------------------
# Add templated files
# ----------------------------------------------------------------------------
Expand Down