Fix trace client memory leak#6856
Merged
Merged
Conversation
crwilcox
approved these changes
Dec 6, 2018
|
@crwilcox please help us to submit this and do a patch release if possible. Thank you |
|
@c24t Thanks for this ! This might actually fix some issues we've been running into where 'too many open files' exceptions crash our VM. Those start occurring because we keep creating new clients / new connections. |
|
When we debug this issue we saw also socket objects being leaked, so I think it is a correlation. |
tseaver
suggested changes
Dec 6, 2018
Contributor
tseaver
left a comment
There was a problem hiding this comment.
Thanks for the patch! We need test coverage for the case that the backing variable is already set, in both the v1 client unit tests and the v2 client unit tests. The new test would look something like:
def test_trace_api_existing(self):
credentials = _make_credentials()
client = self._make_one(project=self.project, credentials=credentials)
client._trace_api = mock.sentinel.trace_api
self.assertIs(client.trace_api, mock.sentinel.trace_api
Contributor
Author
tseaver
suggested changes
Dec 7, 2018
| """Check that the client caches _trace_api.""" | ||
| client = self._make_one(project=self.project, | ||
| credentials=_make_credentials()) | ||
| self.assertIsNone(client._trace_api) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Dec 7, 2018
Contributor
|
Thanks for bearing with me, @c24t! |
This was referenced Dec 7, 2018
ahmetb
pushed a commit
to GoogleCloudPlatform/microservices-demo
that referenced
this pull request
Dec 12, 2018
Enables tracing in the email and recommendation services, which was disabled in 316db88 because of a memory leak in the stackdriver exporter. We fixed the leak in googleapis/google-cloud-python#6856. The fix is included in the [0.1.10 release of opencensus-python](https://github.com/census-instrumentation/opencensus-python/releases/tag/v0.1.10). With this diff, traces show up as expected in stackdriver while running the demo on GKE. Using an `opencensus-python` package version before `0.1.10` causes the email and recommendation services to leak memory until they OOM. Memory use is back to normal (i.e. roughly constant) using the new package version.
neptune-web
added a commit
to neptune-web/kubernetes-microservices-sam
that referenced
this pull request
Jun 12, 2022
Enables tracing in the email and recommendation services, which was disabled in 316db88 because of a memory leak in the stackdriver exporter. We fixed the leak in googleapis/google-cloud-python#6856. The fix is included in the [0.1.10 release of opencensus-python](https://github.com/census-instrumentation/opencensus-python/releases/tag/v0.1.10). With this diff, traces show up as expected in stackdriver while running the demo on GKE. Using an `opencensus-python` package version before `0.1.10` causes the email and recommendation services to leak memory until they OOM. Memory use is back to normal (i.e. roughly constant) using the new package version.
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
oplik0
pushed a commit
to oplik0/bso
that referenced
this pull request
Jun 6, 2024
Enables tracing in the email and recommendation services, which was disabled in 316db88 because of a memory leak in the stackdriver exporter. We fixed the leak in googleapis/google-cloud-python#6856. The fix is included in the [0.1.10 release of opencensus-python](https://github.com/census-instrumentation/opencensus-python/releases/tag/v0.1.10). With this diff, traces show up as expected in stackdriver while running the demo on GKE. Using an `opencensus-python` package version before `0.1.10` causes the email and recommendation services to leak memory until they OOM. Memory use is back to normal (i.e. roughly constant) using the new package version.
Anki15201
pushed a commit
to Anki15201/microservices-demo
that referenced
this pull request
Jul 26, 2025
Enables tracing in the email and recommendation services, which was disabled in 316db88 because of a memory leak in the stackdriver exporter. We fixed the leak in googleapis/google-cloud-python#6856. The fix is included in the [0.1.10 release of opencensus-python](https://github.com/census-instrumentation/opencensus-python/releases/tag/v0.1.10). With this diff, traces show up as expected in stackdriver while running the demo on GKE. Using an `opencensus-python` package version before `0.1.10` causes the email and recommendation services to leak memory until they OOM. Memory use is back to normal (i.e. roughly constant) using the new package version.
dream-work-dev
added a commit
to dream-work-dev/microservices-demo
that referenced
this pull request
Aug 12, 2025
Enables tracing in the email and recommendation services, which was disabled in 316db88 because of a memory leak in the stackdriver exporter. We fixed the leak in googleapis/google-cloud-python#6856. The fix is included in the [0.1.10 release of opencensus-python](https://github.com/census-instrumentation/opencensus-python/releases/tag/v0.1.10). With this diff, traces show up as expected in stackdriver while running the demo on GKE. Using an `opencensus-python` package version before `0.1.10` causes the email and recommendation services to leak memory until they OOM. Memory use is back to normal (i.e. roughly constant) using the new package version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @liyanhui1228
@bogdandrutu and I are seeing a persistent memory leak in projects using the opencensus stackdriver exporter, which uses
google.cloud.trace.client.Clientand repeatedly callsbatch_write_spans.Reusing the trace client's API object fixes the leak.