Continuation of ndb Property implementation (part 5)#6333
Merged
Conversation
Also filling in some missing / incomplete docstrings on recently implemented `Property` methods.
Also cleaning up the `Property._FIND_METHODS_CACHE` in `test_instance_descriptors()`.
chrisrossi
reviewed
Oct 30, 2018
chrisrossi
approved these changes
Oct 30, 2018
chrisrossi
pushed a commit
to chrisrossi/google-cloud-python
that referenced
this pull request
Feb 22, 2019
This is still incomplete, it's a very large class. In particular, this implements: - `Property._get_value` - `Property._delete_value` - `Property._is_initialized` - Descriptors for `Property` (i.e. `__get__`, `__set__` and `__delete__`) - `Property._prepare_for_put` - `Property._check_property` - `Property._get_for_dict`
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
This is still incomplete, it's a very large class. In particular, this implements: - `Property._get_value` - `Property._delete_value` - `Property._is_initialized` - Descriptors for `Property` (i.e. `__get__`, `__set__` and `__delete__`) - `Property._prepare_for_put` - `Property._check_property` - `Property._get_for_dict`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still incomplete, it's a very large class.
In particular, this implements:
Property._get_valueProperty._delete_valueProperty._is_initializedProperty(i.e.__get__,__set__and__delete__)Property._prepare_for_putProperty._check_propertyProperty._get_for_dictLuckily this class is almost finished, with
_serialize,_deserialize,_prepare_for_put(a no-op),_check_propertyand_get_for_dictthe last remaining methods. I think I'll be able to port_serialize|_deserializeto the new protobuf definitions but I haven't looked into it deeply.I'll probably update this PR with the implementations for_prepare_for_put,_check_propertyand_get_for_dictas well.