Skip to content

api_core: retry transient errors in 'PollingFuture.result'. - #6305

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:api_core-future-retry_transient_errors
Oct 31, 2018
Merged

tseaver merged 1 commit into
googleapis:masterfrom
tseaver:api_core-future-retry_transient_errors

Conversation

@tseaver

@tseaver tseaver commented Oct 25, 2018

Copy link
Copy Markdown
Contributor

See: #6301.

@tseaver

tseaver commented Oct 29, 2018

Copy link
Copy Markdown
Contributor Author

@crwilcox ping?

@crwilcox

Copy link
Copy Markdown
Contributor

This LGTM. We retry those errors in some libraries explicitly and they should be retry-able. If not in a hurry, it might be nice to get @theacodes to sign off as well.

@tseaver
tseaver requested a review from theacodes October 30, 2018 19:46
@tseaver
tseaver merged commit f576d14 into googleapis:master Oct 31, 2018
@tseaver
tseaver deleted the api_core-future-retry_transient_errors branch October 31, 2018 14:14
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants