Skip to content

BigQuery: Adds time filtering to client.list_jobs()#5429

Merged
alixhami merged 1 commit into
googleapis:masterfrom
alixhami:bq-time-filter-list-jobs
Jun 1, 2018
Merged

BigQuery: Adds time filtering to client.list_jobs()#5429
alixhami merged 1 commit into
googleapis:masterfrom
alixhami:bq-time-filter-list-jobs

Conversation

@alixhami
Copy link
Copy Markdown
Contributor

@alixhami alixhami commented Jun 1, 2018

Resolves #5067

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Jun 1, 2018
@alixhami alixhami requested review from crwilcox, shollyman and tswast June 1, 2018 19:58
@alixhami alixhami requested a review from lukesneeringer as a code owner June 1, 2018 19:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2018
tseaver
tseaver reviewed Jun 1, 2018
View reviewed changes
Comment thread bigquery/tests/unit/test_client.py
conn = client._connection = _make_connection({})

list(client.list_jobs(
min_creation_time=1, max_creation_time=1527874895820))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

shollyman
shollyman approved these changes Jun 1, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worthy of a quick system test that filters to the last N minutes?

@alixhami
Copy link
Copy Markdown
Contributor Author

alixhami commented Jun 1, 2018

@shollyman Per our in person discussion, I will send another PR expanding the bigquery_list_jobs snippet to include examples of more of the possible arguments (all_users, min_creation_time, max_creation_time). This will serve as an integration test.

@alixhami alixhami merged commit 6f141ff into googleapis:master Jun 1, 2018
@alixhami alixhami deleted the bq-time-filter-list-jobs branch June 1, 2018 23:13
@alixhami alixhami mentioned this pull request Jun 1, 2018
Closed
tswast
tswast reviewed Jun 4, 2018
View reviewed changes
Comment thread bigquery/google/cloud/bigquery/client.py
Optional. How to retry the RPC.
retry (google.api_core.retry.Retry, optional):
How to retry the RPC.
min_creation_time (int, optional):

This comment was marked as spam.

Sign in to view

@tswast tswast mentioned this pull request Jun 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast left review comments

@shollyman shollyman shollyman approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

+2 more reviewers

@tseaver tseaver tseaver left review comments

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alixhami @tseaver @tswast @crwilcox @shollyman @googlebot