Skip to content

BigQuery: Adds Python 3.7 and removes Python 3.4 - #5401

Merged
alixhami merged 2 commits into
googleapis:masterfrom
alixhami:bq-add-3.7
May 29, 2018
Merged

BigQuery: Adds Python 3.7 and removes Python 3.4#5401
alixhami merged 2 commits into
googleapis:masterfrom
alixhami:bq-add-3.7

Conversation

@alixhami

Copy link
Copy Markdown
Contributor

Resolves #5294

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label May 29, 2018
@alixhami
alixhami requested review from crwilcox and tswast May 29, 2018 18:24
@alixhami
alixhami requested a review from tseaver as a code owner May 29, 2018 18:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2018
Comment thread bigquery/nox.py

@nox.session
@nox.parametrize('py', ['2.7', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@tseaver tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR also needs to update the classifiers in setup.py to indicate that we have dropped support for Python 3.4. Note that 3.4 is still the "system" Python for the LTS versions of RHEL and Ubuntu.

@tswast

tswast commented May 29, 2018

Copy link
Copy Markdown
Contributor

@crwilcox Shouldn't all setup.py files get the same update?

@tseaver

tseaver commented May 29, 2018

Copy link
Copy Markdown
Contributor

@tswast Not unless we have made a global choice to drop 3.4 support across all APIs (in which case we should be updating all the corresponding nox.py and setup.py files in lockstep).

@tswast

tswast commented May 29, 2018

Copy link
Copy Markdown
Contributor

Right, wasn't that what #5295 was about? Or did I misinterpret the intent?

@crwilcox crwilcox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment on also updating system but lgtm

@alixhami
alixhami merged commit 8b30a8b into googleapis:master May 29, 2018
@alixhami
alixhami deleted the bq-add-3.7 branch May 29, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants