Skip to content

BigQuery: limit list_jobs sample to 10 most recent jobs#5209

Merged
crwilcox merged 3 commits into
googleapis:masterfrom
tswast:flakey-snippets
Apr 18, 2018
Merged

BigQuery: limit list_jobs sample to 10 most recent jobs#5209
crwilcox merged 3 commits into
googleapis:masterfrom
tswast:flakey-snippets

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Apr 18, 2018

Listing all jobs can take a very long time, especially on a project used
by CI which starts many jobs every test run.

Listing all jobs can take a very long time, especially on a project used
by CI which starts many jobs every test run.
@tswast tswast requested review from alixhami and tseaver April 18, 2018 21:00
@tswast tswast requested a review from lukesneeringer as a code owner April 18, 2018 21:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2018
@alixhami
Copy link
Copy Markdown
Contributor

Looks good, though I think the comment could be more informative. For example:

List the 10 most recent jobs.
If the optional max_results parameter is not used, all jobs will be listed.

@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Apr 18, 2018

though I think the comment could be more informative

Done.

@tswast tswast changed the title BigQuery: limit job listing snippet to 10 results BigQuery: limit list_jobs sample to 10 most recent jobs Apr 18, 2018
@crwilcox crwilcox merged commit 6f46cd7 into googleapis:master Apr 18, 2018
@tswast tswast deleted the flakey-snippets branch April 18, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants