Skip to content

BigQuery: Adds samples from python-docs-samples#5199

Merged
alixhami merged 5 commits into
googleapis:masterfrom
alixhami:bq-samples-repo-move
Apr 17, 2018
Merged

BigQuery: Adds samples from python-docs-samples#5199
alixhami merged 5 commits into
googleapis:masterfrom
alixhami:bq-samples-repo-move

Conversation

@alixhami
Copy link
Copy Markdown
Contributor

There were many redundant samples between google-cloud-python and python-docs-samples. This repo is the primary source of code samples and only had a few missing that were still being sourced from python-docs-samples. This PR adds those few remaining samples so that all samples except quickstart, simple app, and user credentials can be deleted from python-docs-samples.

@alixhami alixhami added documentation api: bigquery Issues related to the BigQuery API. labels Apr 16, 2018
@alixhami alixhami requested a review from tswast April 16, 2018 23:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2018
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming snippets tests pass on Python 2.7.

Comment thread docs/bigquery/snippets.py

open_mock = mock.mock_open(read_data=creds_file_data)

with mock.patch('io.open', open_mock):

This comment was marked as spam.

This comment was marked as spam.

@alixhami alixhami merged commit a0b5c13 into googleapis:master Apr 17, 2018
@alixhami alixhami deleted the bq-samples-repo-move branch April 17, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants